Move Artifact Register FrameInfo #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
reviewed
Jun 27, 2023
There was a problem hiding this comment.
I don't feel comfortable approving here, because I don't know the code and context.
Is @syrusakbary familiar with this?
Otherwise will dig in a bit more to understand it properly.
syrusakbary
reviewed
Jun 27, 2023
syrusakbary
reviewed
Jun 27, 2023
Not sure how. The minimal test written by cosmos doesn't crash all the time. And it's a mater of timing here. |
|
I started to run this patch in infinite loop in our full test suite. There the issue popped up consistently before. Looks good for now. Will let you know if I find something. |
|
With this change I cannot reproduce the issue #3793 anymore. I ran the project's tests for more than 1000 times now. Looking good 🎉 |
syrusakbary
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Artifact Register FrameInfo to a more fitting place. Also register_frameinfo needs a
&mut selfnow to reflect it change a state (even if it's a global static)