Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add "dylib" to the list of default features #2753

Merged
merged 2 commits into from Jan 19, 2022
Merged

Re-add "dylib" to the list of default features #2753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85266ee
Re-add "dylib" to the list of default features
Amanieu Jan 14, 2022
ae66e76
Disable skip_stack_guard_page on dylib due to missing trap info
Amanieu Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Expand Up @@ -88,6 +88,7 @@ default = [
"wat",
"wast",
"universal",
"dylib",
"staticlib",
"cache",
"wasi",
Expand Down
1 change: 1 addition & 0 deletions tests/ignores.txt
View file
Open in desktop
Expand Up @@ -50,6 +50,7 @@ singlepass+windows spec::skip_stack_guard_page # Needs investigation.
cranelift+windows spec::skip_stack_guard_page # Needs investigation. Issue: `STATUS_ACCESS_VIOLATION` trap happened
cranelift+macos spec::skip_stack_guard_page # Needs investigation. process didn't exit successfully: (signal: 6, SIGABRT: process abort signal)
llvm+macos spec::skip_stack_guard_page # Needs investigation. process didn't exit successfully: (signal: 6, SIGABRT: process abort signal)
dylib spec::skip_stack_guard_page # Missing trap information in dylibs


# TODO(https://github.com/wasmerio/wasmer/issues/1727): Traps in dylib engine
Expand Down