Try to enable some tests

wasmerio · Jan 18, 2022 · e188807 · e188807
1 parent 1e5dec6
commit e188807
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/lib/engine-dylib/src/artifact.rs b/lib/engine-dylib/src/artifact.rs
@@ -244,7 +244,7 @@ impl DylibArtifact {
                         get_object_for_target(&target_triple).map_err(to_compile_error)?;
                     emit_trampolines(&mut obj, engine.target());
                     if obj.format() == BinaryFormat::Coff {
-                        obj.add_coff_exports(CoffExportStyle::Msvc);
+                        obj.add_coff_exports(CoffExportStyle::Gnu);
                     }
                     let file = tempfile::Builder::new()
                         .prefix("wasmer_dylib_")
@@ -291,7 +291,7 @@ impl DylibArtifact {
                 emit_compilation(&mut obj, compilation, &symbol_registry, &target_triple)
                     .map_err(to_compile_error)?;
                 if obj.format() == BinaryFormat::Coff {
-                    obj.add_coff_exports(CoffExportStyle::Msvc);
+                    obj.add_coff_exports(CoffExportStyle::Gnu);
                 }
                 let file = tempfile::Builder::new()
                     .prefix("wasmer_dylib_")

diff --git a/tests/ignores.txt b/tests/ignores.txt
@@ -3,7 +3,6 @@ singlepass spec::multi_value # Singlepass has not implemented multivalue (functi
 singlepass spec::simd # Singlepass doesn't support yet SIMD (no one asked for this feature)
 
 singlepass+dylib * # It needs to add support for PIC in Singlepass. Not implemented at the moment
-windows+dylib * # This might be trivial to fix?
 musl+dylib * # Dynamic loading not supported in Musl
 
 # Traps
@@ -33,14 +32,9 @@ llvm       traps::start_trap_pretty
 dylib     traps::start_trap_pretty
 aarch64    traps::start_trap_pretty
 
-cranelift  multi_value_imports::dylib # Needs investigation
 singlepass multi_value_imports::dylib # Singlepass doesn't support multivalue
 singlepass multi_value_imports::dynamic # Singlepass doesn't support multivalue
 
-# LLVM doesn't fully work in macOS M1
-llvm+universal+macos+aarch64 * # We are using the object crate, it was not fully supporting aarch64 relocations emitted by LLVM. Needs reassesment
-llvm+dylib+macos+aarch64 * # Tests seem to be randomly failing
-
 # TODO: We need to fix this in ARM. The issue is caused by libunwind overflowing
 # the stack while creating the stacktrace.
 # https://github.com/rust-lang/backtrace-rs/issues/356