Skip to content

Commit

Permalink
Re-enable dylib engine by default and reset ignores
Browse files Browse the repository at this point in the history
  • Loading branch information
Amanieu committed Jan 14, 2022
1 parent b61778c commit 11d717f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ default = [
"wat",
"wast",
"universal",
"dylib",
"staticlib",
"cache",
"wasi",
Expand Down
15 changes: 15 additions & 0 deletions tests/ignores.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ singlepass spec::multi_value # Singlepass has not implemented multivalue (functi
singlepass spec::simd # Singlepass doesn't support yet SIMD (no one asked for this feature)

singlepass+dylib * # It needs to add support for PIC in Singlepass. Not implemented at the moment
windows+dylib * # This might be trivial to fix?
musl+dylib * # Dynamic loading not supported in Musl

# Traps
Expand Down Expand Up @@ -36,11 +37,25 @@ cranelift multi_value_imports::dylib # Needs investigation
singlepass multi_value_imports::dylib # Singlepass doesn't support multivalue
singlepass multi_value_imports::dynamic # Singlepass doesn't support multivalue

# LLVM doesn't fully work in macOS M1
llvm+universal+macos+aarch64 * # We are using the object crate, it was not fully supporting aarch64 relocations emitted by LLVM. Needs reassesment
llvm+dylib+macos+aarch64 * # Tests seem to be randomly failing

# TODO: We need to fix this in ARM. The issue is caused by libunwind overflowing
# the stack while creating the stacktrace.
# https://github.com/rust-lang/backtrace-rs/issues/356
cranelift+aarch64 spec::skip_stack_guard_page # This is skipped for ARM, not fully fixed yet
llvm+aarch64 spec::skip_stack_guard_page # This is skipped for ARM, not fully fixed yet
singlepass+windows spec::skip_stack_guard_page # Needs investigation.
cranelift+windows spec::skip_stack_guard_page # Needs investigation. Issue: `STATUS_ACCESS_VIOLATION` trap happened
cranelift+macos spec::skip_stack_guard_page # Needs investigation. process didn't exit successfully: (signal: 6, SIGABRT: process abort signal)
llvm+macos spec::skip_stack_guard_page # Needs investigation. process didn't exit successfully: (signal: 6, SIGABRT: process abort signal)


# TODO(https://github.com/wasmerio/wasmer/issues/1727): Traps in dylib engine
cranelift+dylib spec::linking # Needs investigation
cranelift+dylib spec::bulk # Needs investigation

# Some SIMD opperations are not yet supported by Cranelift
# Cranelift just added support for most of those recently, it might be easy to update
cranelift spec::simd::simd_conversions
Expand Down

0 comments on commit 11d717f

Please sign in to comment.