Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for External Release Repository #114

Merged

Conversation

serafdev
Copy link
Contributor

@serafdev serafdev commented Mar 5, 2023

This adds a feature where we can publish the release to an external repository, a good use case on this is when you have a private repository and wish to publish binaries to the public.

Added 2 test repos as an example:

Uploaded a dummy file (go.mod, can be found in the second link above) to test the supported flags from https://github.com/wangyoucao577/assets-uploader:

github-assets-uploader -logtostderr -f go.mod -mediatype application/gzip -repo serafdev/go-release-action-test-public -token REDACTED -tag=v0.0.1-alpha.1 -releasename=v0.0.1-alpha.1 -retry 3

This adds a feature where we can publish the release to an external
repository, a good use case on this is when you have a private
repository and wish to publish binaries to the public.
@@ -71,6 +71,10 @@ inputs:
description: 'Upload binaries to specified release page that indicated by release name.'
required: false
default: ''
release_repo:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add this feature in README.md as well? If you'll use it in production, I'll merge it and release a new version then. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for the heads-up @wangyoucao577, are you able to test-run this before building a new release?

I added it to the documentation but I prefer leaving it out of the YAML examples - most organizations will probably release on the same repository, those that need to release on a different repo will probably dig and read the doc instinctively

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it. So it'll be great if you can help to test it before I release the version!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a real-life example, updated the PR's comment with links to the repositories. Thanks @wangyoucao577 for the support!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged this PR, could you please help to test it with wangyoucao577/go-release-action@master? If it works as expect, I'll release a new version for it. Thanks for your contribution!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyoucao577 wangyoucao577 merged commit b91658d into wangyoucao577:master Mar 12, 2023
serafdev added a commit to serafdev/go-release-action-test-private that referenced this pull request Mar 12, 2023
@serafdev serafdev deleted the feature/external-repo-support branch March 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants