Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): fix type check for jax.Array introduced in jax==0.4.1 #4718

Merged
merged 3 commits into from Jan 4, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 4, 2023

Description

See #4632 (comment) -- the sdk is currently not working with jax==0.4.1 bc of a jax API change.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@github-actions github-actions bot added the cc-fix label Jan 4, 2023
@dmitryduev dmitryduev added this to the sdk-2023-01.1 milestone Jan 4, 2023
@github-actions github-actions bot removed the cc-fix label Jan 4, 2023
@dmitryduev dmitryduev requested a review from a team January 4, 2023 04:18
@github-actions github-actions bot added the cc-fix label Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #4718 (fc47b4b) into main (4f272d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4718   +/-   ##
=======================================
  Coverage   83.29%   83.30%           
=======================================
  Files         280      280           
  Lines       34946    34946           
=======================================
+ Hits        29108    29111    +3     
+ Misses       5838     5835    -3     
Flag Coverage Δ
functest 55.65% <100.00%> (+0.02%) ⬆️
unittest 73.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/util.py 87.26% <100.00%> (ø)
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/wandb_run.py 90.62% <0.00%> (-0.30%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (ø)
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️
wandb/errors/term.py 93.47% <0.00%> (+6.52%) ⬆️

Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants