Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(artifacts): revert fix circular reference detected error when updating metadata with numpy len > 32 #4629

Merged
merged 3 commits into from Dec 14, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Dec 14, 2022

Revert #4221

This reverts commit e632419.

Fixes #4500
Fixes #4554

Description

What does the PR do?

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

…ng metadata with numpy array longer than 32 elements (#4221)"

This reverts commit e632419.
@raubitsj raubitsj changed the title Revert "fix(artifacts): Circular reference detected error when updati… revert(artifacts): revert fix Circular reference detected error, when updating metadata with numpy array longer than 32 elements Dec 14, 2022
@raubitsj raubitsj changed the title revert(artifacts): revert fix Circular reference detected error, when updating metadata with numpy array longer than 32 elements revert(artifacts): revert fix circular reference detected error when updating metadata with numpy len > 32 Dec 14, 2022
@raubitsj raubitsj marked this pull request as ready for review December 14, 2022 02:46
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #4629 (15abd13) into main (e086c26) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4629      +/-   ##
==========================================
+ Coverage   83.20%   83.22%   +0.01%     
==========================================
  Files         279      279              
  Lines       34903    34899       -4     
==========================================
+ Hits        29040    29043       +3     
+ Misses       5863     5856       -7     
Flag Coverage Δ
functest 56.10% <100.00%> (+0.02%) ⬆️
unittest 73.77% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 81.87% <ø> (ø)
wandb/sdk/wandb_artifacts.py 83.69% <ø> (ø)
wandb/util.py 87.44% <ø> (+0.15%) ⬆️
wandb/sdk/interface/interface.py 96.93% <100.00%> (ø)
wandb/sdk/internal/system/assets/interfaces.py 91.95% <0.00%> (-1.15%) ⬇️
wandb/sdk/wandb_run.py 90.60% <0.00%> (-0.24%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (ø)
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️
... and 1 more

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! The PR LGTM, but G released jax==0.4.1 while the CI was running for your last commit, breaking a test we have with the new Array object. Need to look into that!

@raubitsj raubitsj merged commit 2add382 into main Dec 14, 2022
@raubitsj raubitsj deleted the revert-4221-artifact-json branch December 14, 2022 14:39
raubitsj added a commit that referenced this pull request Dec 14, 2022
…updating metadata with numpy len > 32 (#4629)

* Revert "fix(artifacts): Circular reference detected error when updating metadata with numpy array longer than 32 elements (#4221)"

This reverts commit e632419.
bcsherma pushed a commit that referenced this pull request Dec 19, 2022
…updating metadata with numpy len > 32 (#4629)

* Revert "fix(artifacts): Circular reference detected error when updating metadata with numpy array longer than 32 elements (#4221)"

This reverts commit e632419.
@kptkin kptkin added this to the sdk-2022-12.2 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: Artifact cannot be created when metadata contains Tensors with wandb 0.13.5
3 participants