Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(artifacts): add artifact Sequence fallback for older servers #4565

Merged
merged 5 commits into from Dec 3, 2022

Conversation

tssweeney
Copy link
Contributor

Implemented fallback for older servers w.r.t. changes introduced here: https://github.com/wandb/wandb/pull/4531/files

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #4565 (2f3b2b9) into main (bb45a53) will increase coverage by 0.04%.
The diff coverage is 91.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4565      +/-   ##
==========================================
+ Coverage   83.01%   83.06%   +0.04%     
==========================================
  Files         261      261              
  Lines       33262    33271       +9     
==========================================
+ Hits        27614    27637      +23     
+ Misses       5648     5634      -14     
Flag Coverage Δ
functest 56.70% <33.33%> (+0.03%) ⬆️
unittest 73.26% <91.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 82.16% <91.66%> (+0.02%) ⬆️
wandb/sdk/lib/git.py 79.01% <0.00%> (-0.62%) ⬇️
wandb/sdk/wandb_run.py 91.25% <0.00%> (+0.35%) ⬆️
wandb/sdk/lib/sock_client.py 94.70% <0.00%> (+1.58%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 93.82% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@tssweeney tssweeney marked this pull request as ready for review December 3, 2022 00:00
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tssweeney!

@dmitryduev dmitryduev merged commit 47e753d into main Dec 3, 2022
@dmitryduev dmitryduev deleted the model_reg/add_artifact_collection_fallback branch December 3, 2022 00:43
@kptkin kptkin changed the title chore(artifacts): Artifact Sequence Fallbacks chore(artifacts): add artifact Sequence fallback for older servers Dec 6, 2022
@github-actions github-actions bot added cc-chore and removed cc-chore labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants