Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(launch): fix broken queue test #4548

Merged
merged 1 commit into from Nov 29, 2022
Merged

Conversation

gtarpenning
Copy link
Contributor

No description provided.

@gtarpenning gtarpenning marked this pull request as ready for review November 29, 2022 17:04
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #4548 (7cd0176) into main (cb77d21) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4548      +/-   ##
==========================================
+ Coverage   83.08%   83.13%   +0.04%     
==========================================
  Files         259      259              
  Lines       32979    32979              
==========================================
+ Hits        27402    27417      +15     
+ Misses       5577     5562      -15     
Flag Coverage Δ
functest 56.95% <ø> (+0.28%) ⬆️
unittest 73.30% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 90.72% <0.00%> (-0.18%) ⬇️
wandb/sdk/wandb_settings.py 94.45% <0.00%> (+0.13%) ⬆️
wandb/sdk/service/streams.py 94.75% <0.00%> (+0.37%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 89.69% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/git.py 79.01% <0.00%> (+0.61%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
wandb/sdk/internal/file_stream.py 89.86% <0.00%> (+1.01%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.89%) ⬆️

@KyleGoyette KyleGoyette self-requested a review November 29, 2022 17:20
@dmitryduev dmitryduev merged commit 948e0c1 into main Nov 29, 2022
@dmitryduev dmitryduev deleted the griffin/launch/drc-test-fix branch November 29, 2022 20:56
@kptkin kptkin changed the title chore(launch): Fix broken queue test chore(launch): fix broken queue test Dec 6, 2022
@github-actions github-actions bot added cc-chore and removed cc-chore labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants