New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(public-api): change artifactSequence
to artifactCollection
in public GQL requests
#4531
fix(public-api): change artifactSequence
to artifactCollection
in public GQL requests
#4531
Conversation
artifactSequence
to artifactCollection
in public GQL requestsartifactSequence
to artifactCollection
in public GQL requests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4531 +/- ##
==========================================
- Coverage 83.12% 83.11% -0.01%
==========================================
Files 259 259
Lines 32984 32984
==========================================
- Hits 27418 27416 -2
- Misses 5566 5568 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Can we add a quick test to make sure that this successfully pulls from a portfolio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
When this is merged, let's respond to this Github issue here: #4519. We should
There's 2 users who have responded that are using the API to pull artifact versions for the model registry so there must be more out there who have experienced this issue. So I'd like to unblock them as soon as possible. |
Great - i tested in notebook and it works: Note: the |
Created a followup PR to fix the artifact version name issue: #4547 |
artifactSequence
to artifactCollection
in public GQL requestsartifactSequence
to artifactCollection
in public GQL requests
https://wandb.atlassian.net/browse/WB-11598
This is some old tech debt from model reg work. ArtifactCollections should always use the
*Collection
style not*Sequence
.