test(artifacts): use tmp_path fixture instead of writing local files during tests
#4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moredatarequired
changed the title
tmp_path fixture instead of writing local files during teststmp_path fixture instead of writing local files during tests
moredatarequired
changed the title
tmp_path fixture instead of writing local files during teststmp_path fixture instead of writing local files during tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4521 +/- ##
==========================================
+ Coverage 83.08% 83.13% +0.04%
==========================================
Files 259 259
Lines 32979 32979
==========================================
+ Hits 27400 27416 +16
+ Misses 5579 5563 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jlzhao27
approved these changes
Nov 23, 2022
Merged
2 tasks
andrewtruong
pushed a commit
that referenced
this pull request
Dec 2, 2022
…s during tests (#4521) * Use tmp_path fixture instead of writing to the filesystem in tests * Remove unused imports
kptkin
changed the title
tmp_path fixture instead of writing local files during teststmp_path fixture instead of writing local files during tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
os.mkdircalls inside test functions with accepting the pytest built-intmp_pathfixture.Checklist