Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(public-api): upgrade Node 12 based GitHub Actions #4506

Merged
merged 3 commits into from Nov 21, 2022

Conversation

moredatarequired
Copy link
Contributor

@moredatarequired moredatarequired commented Nov 19, 2022

GitHub has deprecated Node 12 based Actions; the two actions we need to update to comply with this are:

  • Update semantic-pull-requests to v5.0.2
  • Checkout to v3 (actually 2.5.0 which is called v3 馃檭 )

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

GitHub has deprecated Node 12 based Actions, and we need to upgrade
in order to move this action to Node 16.
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #4506 (ab0ab90) into main (7426e49) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4506      +/-   ##
==========================================
+ Coverage   83.08%   83.12%   +0.03%     
==========================================
  Files         259      259              
  Lines       32979    32979              
==========================================
+ Hits        27402    27413      +11     
+ Misses       5577     5566      -11     
Flag Coverage 螖
functest 56.94% <酶> (+0.02%) 猬嗭笍
unittest 73.32% <酶> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
wandb/sdk/lib/git.py 79.01% <0.00%> (酶)
wandb/sdk/wandb_run.py 90.89% <0.00%> (+0.23%) 猬嗭笍
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (+2.46%) 猬嗭笍
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) 猬嗭笍

@moredatarequired moredatarequired changed the title chore(public-api): Update semantic-pull-requests to v5.0.2 chore(public-api): Upgrade Node 12 based GitHub Actions Nov 21, 2022
@moredatarequired moredatarequired marked this pull request as ready for review November 21, 2022 19:00
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃檹馃徎

@dmitryduev dmitryduev merged commit 4ad1b6d into main Nov 21, 2022
@dmitryduev dmitryduev deleted the chore/update-semantic-pr-action branch November 21, 2022 19:27
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
* Update semantic-pull-requests to v5.0.2

GitHub has deprecated Node 12 based Actions, and we need to upgrade
in order to move this action to Node 16.

* Use checkout v3 to upgrade to Node 16 action
@kptkin kptkin changed the title chore(public-api): Upgrade Node 12 based GitHub Actions chore(public-api): upgrade Node 12 based GitHub Actions Dec 6, 2022
@github-actions github-actions bot added cc-chore and removed cc-chore labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants