Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): improve Report API in preparation for GA #4499

Merged
merged 123 commits into from Dec 4, 2022

Conversation

andrewtruong
Copy link
Contributor

Fixes WB-11370

Description

Improvements to Report API in preparation for GA

Testing

Cypress, Unit Testing, Notebook Testing

Checklist

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #4499 (b31b6d6) into main (47e753d) will increase coverage by 0.13%.
The diff coverage is 88.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4499      +/-   ##
==========================================
+ Coverage   82.96%   83.09%   +0.13%     
==========================================
  Files         261      267       +6     
  Lines       33271    33739     +468     
==========================================
+ Hits        27602    28036     +434     
- Misses       5669     5703      +34     
Flag Coverage Δ
functest 55.84% <0.42%> (-0.79%) ⬇️
unittest 73.44% <88.92%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_require.py 98.00% <ø> (-0.19%) ⬇️
wandb/apis/reports/validators.py 96.42% <50.00%> (-1.14%) ⬇️
wandb/apis/reports/_helpers.py 79.24% <79.24%> (ø)
wandb/apis/reports/_blocks.py 83.24% <83.24%> (ø)
wandb/apis/reports/report.py 88.35% <88.35%> (ø)
wandb/apis/reports/runset.py 89.01% <89.01%> (ø)
wandb/apis/public.py 81.87% <90.74%> (-0.29%) ⬇️
wandb/apis/reports/util.py 88.57% <93.75%> (+7.25%) ⬆️
wandb/apis/reports/_panels.py 95.79% <95.79%> (ø)
wandb/apis/reports/__init__.py 100.00% <100.00%> (ø)
... and 16 more

@andrewtruong andrewtruong changed the title feat(reports) Improvements to Report API in preparation for GA feat(sdk): Improvements to Report API in preparation for GA Nov 18, 2022
@andrewtruong andrewtruong marked this pull request as ready for review November 24, 2022 00:24
@raubitsj raubitsj added this to the sdk-2022-12.1 milestone Nov 30, 2022
@andrewtruong andrewtruong requested a review from a team as a code owner December 2, 2022 17:29
@andrewtruong andrewtruong force-pushed the andrew/report-api-fixes branch 3 times, most recently from 78eb441 to bc02f0f Compare December 2, 2022 18:15
Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

tests/unit_tests/test_kfp.py Show resolved Hide resolved
wandb/apis/reports/__init__.py Show resolved Hide resolved
wandb/apis/reports/report.py Show resolved Hide resolved
@andrewtruong andrewtruong marked this pull request as draft December 2, 2022 18:54
Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems safe. Only want to understand the queries comparabilities on local servers… are there version where the gql queries will fail? Do we have min version of local for reports requirement?

@andrewtruong andrewtruong marked this pull request as ready for review December 3, 2022 02:44
@andrewtruong andrewtruong enabled auto-merge (squash) December 4, 2022 05:29
@andrewtruong andrewtruong merged commit 202de65 into main Dec 4, 2022
@andrewtruong andrewtruong deleted the andrew/report-api-fixes branch December 4, 2022 21:20
@kptkin kptkin changed the title feat(sdk): Improvements to Report API in preparation for GA feat(sdk): improve Report API in preparation for GA Dec 6, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants