New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): improve Report API in preparation for GA #4499
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
+ Coverage 82.96% 83.09% +0.13%
==========================================
Files 261 267 +6
Lines 33271 33739 +468
==========================================
+ Hits 27602 28036 +434
- Misses 5669 5703 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1ecf5c7
to
52823e6
Compare
78eb441
to
bc02f0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems safe. Only want to understand the queries comparabilities on local servers… are there version where the gql queries will fail? Do we have min version of local for reports requirement?
9f127c2
to
c8389b3
Compare
Fixes WB-11370
Description
Improvements to Report API in preparation for GA
Testing
Cypress, Unit Testing, Notebook Testing
Checklist