Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(launch): remove unused attribute #4497

Merged
merged 1 commit into from Nov 17, 2022

Conversation

jamie-rasmussen
Copy link
Contributor

Description

Removes an attribute that appears to be unused.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #4497 (e5ddc4d) into main (b96107d) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4497      +/-   ##
==========================================
+ Coverage   83.10%   83.14%   +0.04%     
==========================================
  Files         259      259              
  Lines       32980    32979       -1     
==========================================
+ Hits        27408    27421      +13     
+ Misses       5572     5558      -14     
Flag Coverage Δ
functest 56.94% <ø> (+0.01%) ⬆️
unittest 73.33% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/_project_spec.py 93.01% <ø> (-0.03%) ⬇️
wandb/sdk/lib/sock_client.py 93.12% <0.00%> (-1.06%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.89% <0.00%> (ø)
wandb/sdk/lib/mailbox.py 93.49% <0.00%> (+0.34%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 89.69% <0.00%> (+0.51%) ⬆️
wandb/sdk/interface/interface_shared.py 87.33% <0.00%> (+0.77%) ⬆️
... and 3 more

@KyleGoyette KyleGoyette self-assigned this Nov 17, 2022
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drat, I how'd I miss this

@jamie-rasmussen jamie-rasmussen merged commit 37d7538 into main Nov 17, 2022
@jamie-rasmussen jamie-rasmussen deleted the jamie/remove_build_image_attr branch November 17, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants