Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): make protobuf version requirements more granular #4479

Merged
merged 11 commits into from Dec 5, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Nov 10, 2022

Fixes WB-11310

Description

  • Adjust protobuf requirements
  • Add nightly tests for protobuf version compatibility

Testing

CI + locally.
image

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #4479 (8466847) into main (202de65) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
+ Coverage   83.07%   83.10%   +0.02%     
==========================================
  Files         267      267              
  Lines       33739    33739              
==========================================
+ Hits        28030    28039       +9     
+ Misses       5709     5700       -9     
Flag Coverage Δ
functest 55.83% <ø> (+0.03%) ⬆️
unittest 73.45% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (-2.47%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.89% <0.00%> (+0.05%) ⬆️
wandb/sdk/internal/internal_api.py 89.79% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@dmitryduev dmitryduev requested a review from a team November 15, 2022 07:54
@github-actions github-actions bot removed the cc-test label Nov 15, 2022
@dmitryduev dmitryduev self-assigned this Nov 15, 2022
@dmitryduev dmitryduev added this to the sdk-2022-12.1 milestone Nov 15, 2022
@github-actions github-actions bot added cc-test and removed cc-test labels Dec 5, 2022
@dmitryduev dmitryduev changed the title test(sdk): add tests for protobuf version compatibility test(sdk): make protobuf version requirements more granular Dec 5, 2022
@github-actions github-actions bot added cc-test and removed cc-test labels Dec 5, 2022
Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to test on other platforms. Other than that seems great to me!

@dmitryduev dmitryduev merged commit 5b9a80b into main Dec 5, 2022
@dmitryduev dmitryduev deleted the protobuf3-dep branch December 5, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants