Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): support volume mounts and security contexts in kubernetes runner #4475

Merged
merged 21 commits into from Nov 14, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Nov 9, 2022

Fixes WB-11430
Fixes WB-11460
Fixes #NNNN

Description

Adds support for volumes and security contexts for kubernetes runner. Format:

...
"resource_args": {
    "kubernetes": {
        "volumes": [{}],
        "volume_mounts": [{}],
       "security_context": {}
    }
}

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #4475 (ce1f5f7) into main (6ed4569) will increase coverage by 0.02%.
The diff coverage is 81.25%.

❗ Current head ce1f5f7 differs from pull request most recent head c2033e4. Consider uploading reports for the commit c2033e4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4475      +/-   ##
==========================================
+ Coverage   83.02%   83.05%   +0.02%     
==========================================
  Files         259      259              
  Lines       32913    32922       +9     
==========================================
+ Hits        27326    27342      +16     
+ Misses       5587     5580       -7     
Flag Coverage Δ
functest 56.80% <0.00%> (+<0.01%) ⬆️
unittest 73.18% <81.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/runner/kubernetes.py 88.93% <81.25%> (-0.52%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 87.65% <0.00%> (-2.47%) ⬇️
wandb/cli/cli.py 69.10% <0.00%> (-0.10%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/apis/public.py 82.16% <0.00%> (+0.03%) ⬆️
wandb/sdk/wandb_artifacts.py 83.82% <0.00%> (+0.10%) ⬆️
wandb/sdk/internal/internal_api.py 88.91% <0.00%> (+0.12%) ⬆️
wandb/sdk/wandb_run.py 90.85% <0.00%> (+0.17%) ⬆️
wandb/sdk/interface/interface_shared.py 86.82% <0.00%> (+0.25%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@KyleGoyette KyleGoyette changed the title Launch/add kubernetes pods feat(launch): Support volume mounts inm kubernetes runner Nov 10, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Nov 10, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review November 10, 2022 00:16
@KyleGoyette KyleGoyette changed the title feat(launch): Support volume mounts inm kubernetes runner feat(launch): Support volume mounts in kubernetes runner Nov 10, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Nov 10, 2022
@KyleGoyette KyleGoyette changed the title feat(launch): Support volume mounts in kubernetes runner feat(launch): Support volume mounts and security contexts in kubernetes runner Nov 10, 2022
@github-actions github-actions bot removed the cc-feat label Nov 10, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Nov 10, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Nov 10, 2022
@KyleGoyette KyleGoyette merged commit d0df1dd into main Nov 14, 2022
@KyleGoyette KyleGoyette deleted the launch/add-kubernetes-pods branch November 14, 2022 17:45
@kptkin kptkin changed the title feat(launch): Support volume mounts and security contexts in kubernetes runner feat(launch): support volume mounts and security contexts in kubernetes runner Dec 6, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants