Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix probing static IPU info #4464

Merged
merged 2 commits into from Nov 10, 2022
Merged

fix(sdk): fix probing static IPU info #4464

merged 2 commits into from Nov 10, 2022

Conversation

dmitryduev
Copy link
Member

Fixes WB-NNNN
Fixes #NNNN

Description

Fix a bug in the IPU probe.

Testing

CI + manual.

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #4464 (6e52d5f) into main (eddc2ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4464   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files         258      258           
  Lines       32870    32871    +1     
=======================================
+ Hits        27292    27296    +4     
+ Misses       5578     5575    -3     
Flag Coverage Δ
functest 56.87% <0.00%> (+0.01%) ⬆️
unittest 73.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/system/assets/ipu.py 95.78% <100.00%> (+0.04%) ⬆️
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (-0.62%) ⬇️
wandb/sdk/wandb_run.py 90.67% <0.00%> (-0.30%) ⬇️
wandb/cli/cli.py 69.20% <0.00%> (+0.09%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

kptkin pushed a commit that referenced this pull request Nov 9, 2022
@dmitryduev dmitryduev added this to the sdk-2022-11.2 milestone Nov 10, 2022
@dmitryduev dmitryduev merged commit 61bdf1a into main Nov 10, 2022
@dmitryduev dmitryduev deleted the fix-ipu-probe branch November 10, 2022 20:25
@dmitryduev dmitryduev modified the milestones: sdk-2022-11.2, sdk-2022-12.1 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants