Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(launch): improved git fetch time by specifying a refspec and depth=1 #4459

Merged
merged 3 commits into from
Nov 8, 2022
Merged

chore(launch): improved git fetch time by specifying a refspec and depth=1 #4459

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae7d7af
first pass, massive improvements in fetch efficiency
gtarpenning Nov 8, 2022
9ce39c9
wip with explicit sha handling
gtarpenning Nov 8, 2022
e56b68b
stripped down version
gtarpenning Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion wandb/sdk/launch/utils.py
View file
Open in desktop
Expand Up @@ -414,6 +414,20 @@ def apply_patch(patch_string: str, dst_dir: str) -> None:
raise wandb.Error("Failed to apply diff.patch associated with run.")


def _make_refspec_from_version(version: Optional[str]) -> List[str]:
"""
Helper to create a refspec that checks for the existence of origin/main
and the version, if provided.
"""
if version:
return [f"+{version}"]

return [
"+refs/heads/main*:refs/remotes/origin/main*",
"+refs/heads/master*:refs/remotes/origin/master*",
]


def _fetch_git_repo(dst_dir: str, uri: str, version: Optional[str]) -> str:
"""Clones the git repo at ``uri`` into ``dst_dir``.

Expand All @@ -428,7 +442,8 @@ def _fetch_git_repo(dst_dir: str, uri: str, version: Optional[str]) -> str:
_logger.info("Fetching git repo")
repo = git.Repo.init(dst_dir)
origin = repo.create_remote("origin", uri)
origin.fetch()
refspec = _make_refspec_from_version(version)
origin.fetch(refspec=refspec, depth=1)

if version is not None:
try:
Expand Down