fix(sdk): add support for service running in a pex based environment #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kptkin
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 258 258
Lines 32870 32875 +5
=======================================
+ Hits 27292 27299 +7
+ Misses 5578 5576 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vanpelt
reviewed
Nov 8, 2022
wandb/sdk/wandb_settings.py
Outdated
| # one special case here is running inside a PEX environment, | ||
| # see https://pex.readthedocs.io/en/latest/index.html for more info about PEX | ||
| settings["_executable"] = ( | ||
| self._executable or os.environ.get("PEX") or sys.executable |
There was a problem hiding this comment.
I was just looking at the official docs and sys.executable can return empty string or None. I imagine it makes more sense to fall back to "python" as the executable if we can't get an absolute path...
vanpelt
reviewed
Nov 8, 2022
wandb/sdk/service/service.py
Outdated
| @@ -82,7 +85,8 @@ def _launch_server(self) -> None: | |||
| fname = os.path.join(tmpdir, f"port-{pid}.txt") | |||
|
|
|||
| pid_str = str(os.getpid()) | |||
| exec_cmd_list = [sys.executable, "-m"] | |||
| executable = self._python_executable or sys.executable | |||
There was a problem hiding this comment.
I think or "python" would be reasonable here. There are other places in the codebase where we assume sys.executable will be a python interpreter that we should fix as well so maybe a util / helper is appropriate.
There was a problem hiding this comment.
ah good catch, will do!
andrewtruong
pushed a commit
that referenced
this pull request
Dec 2, 2022
…4440) * fix pex * python_executable -> settings * add a test * fix(sdk): pex pex pex * fix config * oomny v goroo ne poidyot * oomny v goroo ne poidyot * oora my lomim gnutsya shvedy * oora my lomim gnutsya shvedy * oora my lomim gnutsya shvedy * oora my lomim gnutsya shvedy * oora my lomim gnutsya shvedy * oora my lomim gnutsya shvedy * replace borky yea test with a (borky) circle job * clean up * lint Co-authored-by: Dmitry Duev <dima@wandb.com> Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-11018
Description
What does the PR do?
Based on this discussion in the pex repo: pex-tool/pex#626 (comment) it seems that the correct way to use an executable when running with pex is the use the
sys.argvand based on this PR the way to find out if you are in a pex environment is based on this environment variable: pex-tool/pex#1495Testing
How was this PR tested?
Checklist