Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sweeps): add Sweep.expected_run_count to public Api #4434

Merged
merged 14 commits into from Nov 10, 2022

Conversation

gtarpenning
Copy link
Contributor

https://wandb.atlassian.net/browse/WB-11414

Description

Adds expected run count -- now with a legacy fallback query

Testing

added testing in test_public_api.py

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #4434 (35e2c68) into main (61bdf1a) will decrease coverage by 0.02%.
The diff coverage is 69.23%.

❗ Current head 35e2c68 differs from pull request most recent head ad3a199. Consider uploading reports for the commit ad3a199 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4434      +/-   ##
==========================================
- Coverage   83.05%   83.03%   -0.03%     
==========================================
  Files         259      258       -1     
  Lines       32906    32876      -30     
==========================================
- Hits        27330    27298      -32     
- Misses       5576     5578       +2     
Flag Coverage Δ
functest 56.87% <23.07%> (+0.05%) ⬆️
unittest 73.14% <69.23%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 81.80% <69.23%> (-0.36%) ⬇️
wandb/sklearn/plot/classifier.py 88.15% <0.00%> (-8.91%) ⬇️
wandb/sdk/launch/builder/loader.py 80.00% <0.00%> (-3.34%) ⬇️
wandb/sdk/service/service.py 89.15% <0.00%> (-0.13%) ⬇️
wandb/sdk/wandb_run.py 90.91% <0.00%> (-0.12%) ⬇️
wandb/sdk/launch/utils.py 92.48% <0.00%> (-0.11%) ⬇️
wandb/sdk/wandb_artifacts.py 83.71% <0.00%> (-0.11%) ⬇️
wandb/sdk/internal/settings_static.py 93.75% <0.00%> (-0.10%) ⬇️
wandb/sdk/internal/system/assets/ipu.py 95.74% <0.00%> (-0.05%) ⬇️
... and 10 more

@gtarpenning gtarpenning marked this pull request as ready for review November 4, 2022 17:15
wandb/apis/public.py Outdated Show resolved Hide resolved
@gtarpenning gtarpenning merged commit 27a13cc into main Nov 10, 2022
@gtarpenning gtarpenning deleted the sweeps/expected-run-count-None branch November 10, 2022 23:03
@kptkin kptkin changed the title feat(sweeps): Adds Sweep.expected_run_count to public Api feat(sweeps): add Sweep.expected_run_count to public Api Dec 6, 2022
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants