New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sweeps): add Sweep.expected_run_count
to public Api
#4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
==========================================
- Coverage 83.05% 83.03% -0.03%
==========================================
Files 259 258 -1
Lines 32906 32876 -30
==========================================
- Hits 27330 27298 -32
- Misses 5576 5578 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gtarpenning
force-pushed
the
sweeps/expected-run-count-None
branch
from
November 7, 2022 18:15
63c706e
to
508227f
Compare
gtarpenning
force-pushed
the
sweeps/expected-run-count-None
branch
from
November 8, 2022 20:41
425cee4
to
35e2c68
Compare
KyleGoyette
reviewed
Nov 10, 2022
KyleGoyette
reviewed
Nov 10, 2022
KyleGoyette
approved these changes
Nov 10, 2022
andrewtruong
pushed a commit
that referenced
this pull request
Dec 2, 2022
kptkin
changed the title
feat(sweeps): Adds Sweep.expected_run_count to public Api
feat(sweeps): add Dec 6, 2022
Sweep.expected_run_count
to public Api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wandb.atlassian.net/browse/WB-11414
Description
Adds expected run count -- now with a legacy fallback query
Testing
added testing in
test_public_api.py
Checklist