New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integrations): fix TF compatibility issues with WandbModelCheckpoint
#4432
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4432 +/- ##
==========================================
- Coverage 83.02% 82.98% -0.05%
==========================================
Files 261 261
Lines 33242 33257 +15
==========================================
- Hits 27600 27599 -1
- Misses 5642 5658 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM. Thanks!
Hey @dmitryduev is this PR ready to be merged? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ayulockin - please see my comments.
@@ -171,3 +181,10 @@ def _check_filepath(self) -> None: | |||
"This ensures correct interpretation of the logged artifacts.", | |||
repeat=False, | |||
) | |||
|
|||
def _patch_tf_keras_version(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name is a bit misleading as you're not patching anything... I'd do something like
self._is_old_tf_keras_version: Optional[bool] = None
in init
then
convert this one into a property called is_old_tf_keras_version that sets the private self._is_old_tf_keras_version on first invocation and then just returns it -- there's no need to recalculate it every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caching was not fixed, I added it in 67756e1
Hey @dmitryduev I made the changes as per your feedback. However, I am not sure if I did this correctly: "You need to add this new shard to both tox.ini and Circle config.yml for the tests to be run." Also |
Hey @dmitryduev the I am getting the same |
WandbModelCheckpoint
Fixes GROWTH2-109
Description
This PR fixes compatibility issue of
WandbModelCheckpoint
with TF version < 2.6.0.Co-author: @ayulockin
Testing
How was this PR tested?
Checklist