Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(launch): new shard for launch tests #4427

Merged
merged 13 commits into from Nov 11, 2022
Merged

Conversation

gtarpenning
Copy link
Contributor

@gtarpenning gtarpenning commented Nov 2, 2022

Jira Ticket:
https://wandb.atlassian.net/browse/WB-11400

Description

Adds to a new circle test for specific launch related tests in the new relay-server suite.

Testing

Testing in draft PR, circle CI check

@github-actions github-actions bot added cc-chore and removed cc-chore labels Nov 2, 2022
@gtarpenning gtarpenning marked this pull request as ready for review November 2, 2022 00:18
@github-actions github-actions bot added cc-chore and removed cc-chore labels Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #4427 (f316728) into main (61bdf1a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f316728 differs from pull request most recent head 47d3a24. Consider uploading reports for the commit 47d3a24 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4427      +/-   ##
==========================================
- Coverage   83.05%   83.04%   -0.01%     
==========================================
  Files         259      259              
  Lines       32906    32906              
==========================================
- Hits        27330    27328       -2     
- Misses       5576     5578       +2     
Flag Coverage Δ
functest 56.83% <ø> (+0.01%) ⬆️
unittest 73.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/lib/sock_client.py 93.12% <0.00%> (-1.06%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/sdk/wandb_run.py 90.73% <0.00%> (-0.30%) ⬇️
wandb/sdk/internal/internal_api.py 88.78% <0.00%> (-0.13%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_settings.py 94.73% <0.00%> (+0.27%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@gtarpenning
Copy link
Contributor Author

@kptkin Do you think these tests aren't passing because of something related to the Circle changes in this PR?

@kptkin
Copy link
Contributor

kptkin commented Nov 4, 2022

@kptkin Do you think these tests aren't passing because of something related to the Circle changes in this PR?

probably, will need to debug the config files

pytest.ini Outdated Show resolved Hide resolved
@gtarpenning gtarpenning enabled auto-merge (squash) November 10, 2022 23:38
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gtarpenning gtarpenning merged commit 6ed4569 into main Nov 11, 2022
@gtarpenning gtarpenning deleted the launch/launch-shard branch November 11, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants