Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): add filter for artifact_version to only retrieve committed artifacts #4401

Merged
merged 7 commits into from Nov 4, 2022

Conversation

estellazx
Copy link
Contributor

@estellazx estellazx commented Oct 21, 2022

Fixes WB-10948
https://wandb.atlassian.net/browse/WB-10948

Description

Add filter for artifact_version to only retrieve committed artifacts

Testing

Manually tested on dev

Copy link
Contributor

@speezepearson speezepearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4401 (fa85c11) into main (a3eec65) will increase coverage by 8.57%.
The diff coverage is 100.00%.

❗ Current head fa85c11 differs from pull request most recent head 2e9e0fd. Consider uploading reports for the commit 2e9e0fd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4401      +/-   ##
==========================================
+ Coverage   74.06%   82.63%   +8.57%     
==========================================
  Files         258      258              
  Lines       32863    32866       +3     
==========================================
+ Hits        24339    27160    +2821     
+ Misses       8524     5706    -2818     
Flag Coverage Δ
functest 56.32% <0.00%> (-0.54%) ⬇️
unittest 73.16% <100.00%> (+15.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 82.07% <100.00%> (+3.22%) ⬆️
wandb/integration/prodigy/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
wandb/integration/prodigy/prodigy.py 0.00% <0.00%> (-95.00%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/sdk/lib/sock_client.py 93.12% <0.00%> (ø)
wandb/env.py 74.89% <0.00%> (+0.86%) ⬆️
wandb/sdk/internal/tb_watcher.py 88.03% <0.00%> (+0.99%) ⬆️
wandb/sdk/lib/ipython.py 41.89% <0.00%> (+1.35%) ⬆️
wandb/sdk/lib/mailbox.py 93.49% <0.00%> (+1.36%) ⬆️
wandb/sdk/wandb_manager.py 94.07% <0.00%> (+1.48%) ⬆️
... and 91 more

@github-actions github-actions bot added cc-fix and removed cc-fix labels Nov 3, 2022
@estellazx estellazx enabled auto-merge (squash) November 3, 2022 14:36
@estellazx estellazx enabled auto-merge (squash) November 4, 2022 16:21
@estellazx estellazx merged commit 7591f09 into main Nov 4, 2022
@estellazx estellazx deleted the deleteVersion branch November 4, 2022 16:32
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
… artifacts (#4401)

fix(artifacts): have default artifactVersions only retrieve commmited artifacts

Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com>
@kptkin kptkin changed the title fix(artifacts): have default artifactVersions only retrieve committed artifacts fix(artifacts): add filter for artifact_version to only retrieve committed artifacts Dec 6, 2022
@kptkin kptkin changed the title fix(artifacts): add filter for artifact_version to only retrieve committed artifacts fix(artifacts): add filter for artifact_version to only retrieve committed artifacts Dec 6, 2022
@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants