New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add ability to log learning rate using WandbMetricsLogger #4391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soumik12345. Please fix the issues reported by mypy, they are all real. + looks like your functional test is either non-deterministic or something else is going on there.
Please ensure the CI is green as much as possible before marking the PR as ready for review and requesting reviews.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4391 +/- ##
=======================================
Coverage 83.10% 83.11%
=======================================
Files 259 259
Lines 32984 33006 +22
=======================================
+ Hits 27413 27434 +21
- Misses 5571 5572 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soumik12345 the CI is still red, please address.
@ayulockin I don't think that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @soumik12345 @ayulockin. A few requests + would appreciate input on the system metrics stuff (see above).
Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com>
@ayulockin , @soumik12345 can you update the name and description of the PR to reflect the broader updates that were added please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please add the tests (see comments) and it should be good to go in.
Hey @dmitryduev should we have separate tests to cover the missing logics. Since we are only using |
@ayulockin yea, adding more yea tests is probably the simplest thing to do here. |
Adds GROWTH2-77
Description
Add support for tracking learning rate with
WandbMetricsLogger
Testing
How was this PR tested?
Checklist
cc: @ayulockin @dmitryduev
Re-raising #4378