Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): adds an option to force pull the latest version of a test dev-container image #4352

Merged
merged 9 commits into from Nov 10, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Oct 5, 2022

Fixes WB-11157

Description

What does the PR do?

This PR adds a command line argument to force pull the latest version of a specific test container

Testing

How was this PR tested?

tested locally by myself and @ssisk

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #4352 (221bf89) into main (dbe05ea) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4352      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         258      258              
  Lines       32893    32893              
==========================================
- Hits        27317    27316       -1     
- Misses       5576     5577       +1     
Flag Coverage Δ
functest 56.85% <ø> (+0.02%) ⬆️
unittest 73.20% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/tensorboard/monkeypatch.py 87.65% <0.00%> (-2.47%) ⬇️
wandb/sdk/internal/internal_api.py 88.91% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.44% <0.00%> (-0.51%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.97% <0.00%> (+0.05%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@kptkin kptkin changed the title add option to pull latest version of an image chore(sdk): adds an option to force pull the latest version of a test dev-container image Oct 5, 2022
@kptkin kptkin marked this pull request as ready for review October 5, 2022 17:29
@kptkin kptkin requested review from a team and ssisk October 5, 2022 17:30
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kptkin kptkin added this to the sdk-2022-12.1 milestone Nov 9, 2022
@kptkin kptkin enabled auto-merge (squash) November 10, 2022 03:52
@kptkin kptkin merged commit 8daca3b into main Nov 10, 2022
@kptkin kptkin deleted the WB-11157 branch November 10, 2022 15:30
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
… dev-container image (#4352)

* add option to pull latest version of an image

* lint

* address reviewer comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants