New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch): noop builder #4275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4275 +/- ##
==========================================
- Coverage 83.01% 82.56% -0.45%
==========================================
Files 258 245 -13
Lines 32865 31562 -1303
==========================================
- Hits 27282 26060 -1222
+ Misses 5583 5502 -81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…nto launch/no-default-builder
…nto launch/no-default-builder
gtarpenning
approved these changes
Sep 15, 2022
KyleGoyette
requested review from
jamie-rasmussen
and removed request for
hu-po
November 10, 2022 15:55
jamie-rasmussen
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-10907
Fixes #NNNN
Description
Adds a noop builder option for users who dont want a builder
Testing
How was this PR tested?
Checklist