Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): noop builder #4275

Merged
merged 31 commits into from Nov 10, 2022
Merged

feat(launch): noop builder #4275

merged 31 commits into from Nov 10, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Sep 15, 2022

Fixes WB-10907
Fixes #NNNN

Description

Adds a noop builder option for users who dont want a builder

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #4275 (d730657) into main (a6d6e2d) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head d730657 differs from pull request most recent head 21f0f42. Consider uploading reports for the commit 21f0f42 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
- Coverage   83.01%   82.56%   -0.45%     
==========================================
  Files         258      245      -13     
  Lines       32865    31562    -1303     
==========================================
- Hits        27282    26060    -1222     
+ Misses       5583     5502      -81     
Flag Coverage Δ
functest 55.72% <0.00%> (-1.13%) ⬇️
unittest 73.10% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/builder/loader.py 83.33% <100.00%> (+3.33%) ⬆️
wandb/sdk/launch/builder/noop.py 100.00% <100.00%> (ø)
wandb/sdk/data_types/base_types/media.py 92.08% <0.00%> (-4.45%) ⬇️
wandb/sdk/data_types/image.py 82.95% <0.00%> (-2.94%) ⬇️
wandb/sdk/internal/internal_api.py 86.46% <0.00%> (-2.45%) ⬇️
wandb/sdk/internal/settings_static.py 91.30% <0.00%> (-2.45%) ⬇️
wandb/sdk/data_types/object_3d.py 93.75% <0.00%> (-2.37%) ⬇️
wandb/sdk/wandb_artifacts.py 81.83% <0.00%> (-1.99%) ⬇️
wandb/sdk/interface/interface_shared.py 85.88% <0.00%> (-1.46%) ⬇️
wandb/sdk/internal/artifacts.py 87.50% <0.00%> (-1.05%) ⬇️
... and 54 more

@KyleGoyette KyleGoyette changed the title Launch/no default builder feat(launch): noop builder Sep 15, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review September 15, 2022 20:35
wandb/sdk/launch/builder/noop.py Outdated Show resolved Hide resolved
@KyleGoyette KyleGoyette requested review from jamie-rasmussen and removed request for hu-po November 10, 2022 15:55
@KyleGoyette KyleGoyette merged commit d09938f into main Nov 10, 2022
@KyleGoyette KyleGoyette deleted the launch/no-default-builder branch November 10, 2022 16:36
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants