Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(artifacts): when artifact-commit 409s, retry entire artifact-creation, not just commit #4272

Closed
wants to merge 30 commits into from
Closed

fix(artifacts): when artifact-commit 409s, retry entire artifact-creation, not just commit #4272

wants to merge 30 commits into from

Commits on Sep 13, 2022

  1. retry 409s at higher level

    @speezepearson
    speezepearson committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e7b566f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. refactor out _retry_conflicts

    @speezepearson
    speezepearson committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dd7e37e View commit details
    Browse the repository at this point in the history

  2. introduce ad-hoc Future class to avoid awkward nonlocal var

    @speezepearson
    speezepearson committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    8cb6ab5 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. add explanatory comment

    @speezepearson
    speezepearson committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    436c178 View commit details
    Browse the repository at this point in the history

  2. make functionally-public function actually-public

    @speezepearson
    speezepearson committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    b5c74ec View commit details
    Browse the repository at this point in the history

  3. fix retry logic by introducing class ArtifactCommitFailed

    @speezepearson
    speezepearson committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    25b9693 View commit details
    Browse the repository at this point in the history

  4. lint

    @speezepearson
    speezepearson committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    8749102 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Merge branch 'master' into spencerpearson/retry-conflict-higher-level

    @speezepearson
    speezepearson committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    fcc93ab View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Merge remote-tracking branch 'origin/master' into spencerpearson/retr… 

    …y-conflict-higher-level
    @speezepearson
    speezepearson committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    cdd2401 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'spencerpearson/no-retry-conflict' into spencerpearson/r… 

    …etry-conflict-higher-level
    @kptkin
    kptkin committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    153932c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. wip

    @speezepearson
    speezepearson committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2ad2ca3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. test(artifacts): add test for artifact retries, and GraphQL-injection… 

    … support for RelayServer
    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    72e8efa View commit details
    Browse the repository at this point in the history

  2. remove dead code

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    86258be View commit details
    Browse the repository at this point in the history

  3. undo failed attempt to make make RelayServer error reporting better

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    95f7cf1 View commit details
    Browse the repository at this point in the history

  4. add test for retry on 409

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a0d01ba View commit details
    Browse the repository at this point in the history

  5. Merge branch 'spencerpearson/no-retry-conflict' into spencerpearson/r… 

    …etry-conflict-higher-level
    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    394c448 View commit details
    Browse the repository at this point in the history

  6. lint

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a85d0a6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into spencerpearson/relay-graphql

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7021af8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'spencerpearson/relay-graphql' into spencerpearson/retry… 

    …-conflict-higher-level
    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    db47ded View commit details
    Browse the repository at this point in the history

  9. lint

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4cb2d1b View commit details
    Browse the repository at this point in the history

  10. undo unnecessary isort changes

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d338460 View commit details
    Browse the repository at this point in the history

  11. lint

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f34121d View commit details
    Browse the repository at this point in the history

  12. fix Resolver methods, and make them stylistically more-closely-resemb… 

    …le existing ones
    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b980fea View commit details
    Browse the repository at this point in the history

  13. fix Resolver methods, and make them stylistically more-closely-resemb… 

    …le existing ones
    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    0a6b526 View commit details
    Browse the repository at this point in the history

  14. improve typing, add assertion

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    75f4a1e View commit details
    Browse the repository at this point in the history

  15. undo unnecessary changes

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4882721 View commit details
    Browse the repository at this point in the history

  16. make test more precise

    @speezepearson
    speezepearson committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8ef08a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. fix test

    @speezepearson
    speezepearson committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    26a41fb View commit details
    Browse the repository at this point in the history

  2. fix more tests by not assuming every context-entry has a config key

    @speezepearson
    speezepearson committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    cc526df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'spencerpearson/relay-graphql' into spencerpearson/retry… 

    …-conflict-higher-level
    @speezepearson
    speezepearson committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    1c719e0 View commit details
    Browse the repository at this point in the history