Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modelreg) : add the ability to log artifact while linking to registered model #4233

Merged
merged 5 commits into from Sep 6, 2022

Conversation

ibindlish
Copy link
Contributor

Fixes WB-10604
Fixes #4090

Description

Allows an artifact to be linked to a registered model via link_artifact even if it hasn't been logged yet.

Testing

functional yea tests
modified link-artifact.py

Checklist

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #4233 (627d36f) into master (54d64ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 627d36f differs from pull request most recent head d0e1ecb. Consider uploading reports for the commit d0e1ecb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4233      +/-   ##
==========================================
+ Coverage   82.63%   82.68%   +0.04%     
==========================================
  Files         256      256              
  Lines       32608    32602       -6     
==========================================
+ Hits        26945    26956      +11     
+ Misses       5663     5646      -17     
Flag Coverage Δ
functest 55.99% <100.00%> (+0.05%) ⬆️
unittest 73.44% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 90.89% <100.00%> (-0.24%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/apis/public.py 82.57% <0.00%> (+0.26%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 86.98% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/sdk/launch/agent/agent.py 92.25% <0.00%> (+1.40%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

Copy link
Contributor

@vwrj vwrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

wandb/sdk/wandb_run.py Show resolved Hide resolved
@dmitryduev dmitryduev enabled auto-merge (squash) September 6, 2022 22:17
@dmitryduev dmitryduev merged commit dfbcbb7 into master Sep 6, 2022
@dmitryduev dmitryduev deleted the link-log-artifact branch September 6, 2022 23:45
@dmitryduev dmitryduev added this to the sdk-2022-09.1 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: unable to link artifact to model registry
3 participants