Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added telemetry for keras-cv #4196

Merged
merged 8 commits into from Sep 6, 2022
Merged

Conversation

manangoel99
Copy link
Contributor

Fixes Growth-330

Description

This PR adds telemetry for keras-cv

Checklist

  • Include reference to internal ticket "Fixes Growth-330"

@manangoel99 manangoel99 marked this pull request as ready for review August 30, 2022 08:05
@manangoel99
Copy link
Contributor Author

Getting this error for the failing tests

Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication

Copy link
Member

@morganmcg1 morganmcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, @dmitryduev does @manangoel99 need permissions to run some of the tests?

@dmitryduev dmitryduev added this to the sdk-2022-09.1 milestone Sep 6, 2022
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manangoel99: our new pytest tests (unit-s_base-lin-py3*) use local-testcontainer and can't execute in PRs from forks yet. For now please create branches directly in wandb/wandb.

@dmitryduev dmitryduev merged commit 3021afc into wandb:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants