New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make pulling sweeps optional when using public api to query for runs #4186
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4186 +/- ##
==========================================
+ Coverage 82.54% 82.68% +0.14%
==========================================
Files 256 256
Lines 32612 32602 -10
==========================================
+ Hits 26918 26957 +39
+ Misses 5694 5645 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One comment: can we properly test this now? |
Do you mean performance test? Or that we don’t pull the sweep info? |
@kptkin: just that we don't pull in the info |
Fixes WB-9297
Description
What does the PR do?
This PR allows users to specify if they want to pull the sweeps (when pulling the runs) with the
Api.runs
method. The default staysTrue
for backward compatibility, however the user could specifyApi.runs(..., include_sweeps=False)
in case they don't need sweeps and save time. From my simple example it seems to reduce the fetch time by ~3.6-5.9x.Testing
How was this PR tested?
Manually