Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-10394] add detail to error message when uploading an artifact with the wrong type #4184

Merged
merged 3 commits into from Aug 31, 2022

Conversation

speezepearson
Copy link
Contributor

@speezepearson speezepearson commented Aug 25, 2022

Fixes WB-10394

Testing

Shouldn't affect anything, so, relying on the existing test suite!

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4184 (a36ba63) into master (939c8c7) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a36ba63 differs from pull request most recent head c545255. Consider uploading reports for the commit c545255 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4184      +/-   ##
==========================================
- Coverage   82.66%   82.63%   -0.03%     
==========================================
  Files         256      256              
  Lines       32569    32541      -28     
==========================================
- Hits        26922    26891      -31     
- Misses       5647     5650       +3     
Flag Coverage Δ
functest 55.96% <ø> (+0.02%) ⬆️
unittest 73.38% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 90.92% <ø> (-0.20%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (-2.47%) ⬇️
wandb/sdk/lib/sock_client.py 92.59% <0.00%> (-1.59%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (-0.62%) ⬇️
wandb/sdk/internal/internal_api.py 86.46% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.44% <0.00%> (-0.51%) ⬇️
wandb/sdk/wandb_manager.py 93.84% <0.00%> (-0.23%) ⬇️
wandb/util.py 86.87% <0.00%> (-0.02%) ⬇️
wandb/apis/public.py 82.64% <0.00%> (+0.07%) ⬆️
... and 3 more

@dmitryduev dmitryduev enabled auto-merge (squash) August 26, 2022 00:27
@dmitryduev dmitryduev merged commit 1aa0e5a into master Aug 31, 2022
@dmitryduev dmitryduev deleted the spencerpearson/artifact-type-errmsg branch August 31, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants