Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): put job into artifact slot, have run use it, dont produce a job in a launched run that is sourced from a job #4183

Merged
merged 6 commits into from Aug 26, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Aug 25, 2022

Fixes WB-10747
Fixes WB-10746
Fixes #NNNN

Description

Puts the job in the artifacts dict and automatically uses it.
so

  1. We can now filter by jobs using this job
  2. We dont try to produce a new job version when sourced from a job

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4183 (bca6a47) into master (6f330d4) will increase coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4183   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files         256      256           
  Lines       32546    32555    +9     
=======================================
+ Hits        26900    26908    +8     
- Misses       5646     5647    +1     
Flag Coverage Δ
functest 55.96% <40.00%> (+0.03%) ⬆️
unittest 73.38% <70.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 90.87% <50.00%> (-0.30%) ⬇️
wandb/sdk/wandb_init.py 85.58% <66.66%> (-0.11%) ⬇️
wandb/sdk/launch/builder/build.py 89.70% <75.00%> (-0.35%) ⬇️
wandb/util.py 86.89% <100.00%> (+0.01%) ⬆️
wandb/cli/cli.py 68.80% <0.00%> (-0.10%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (ø)
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@KyleGoyette KyleGoyette changed the title put job into artifact slot, have run use it feat(launch): put job into artifact slot, have run use it, dont produce a job in a launched run that used a job Aug 25, 2022
@KyleGoyette KyleGoyette changed the title feat(launch): put job into artifact slot, have run use it, dont produce a job in a launched run that used a job feat(launch): put job into artifact slot, have run use it, dont produce a job in a launched run that is sourced from a job Aug 25, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review August 25, 2022 20:28
Copy link
Contributor

@hu-po hu-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an artifacts noob I approve this PR.

@KyleGoyette KyleGoyette merged commit f838ebe into master Aug 26, 2022
@KyleGoyette KyleGoyette deleted the jobs/handle-runs-from-jobs branch August 26, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants