feat(artifacts): add optional timeout parameter to artifacts wait()

[estellazx]

Fixes WB-8590

Description

Add optional timeout parameter to Artifact.wait()

Testing

Unit tests testing that the wait() fails if the timeout runs out and wait() successes when there is no timeout or wait is finished faster than timeout

Checklist

• Link to ticket: https://wandb.atlassian.net/jira/software/c/projects/WB/boards/62?modal=detail&selectedIssue=WB-8590

[KyleGoyette]

Generally LGTM, concerned about just how big the array is for the test failure with the 2 second timeout. Maybe we should just test the 0 second time out?

[speezepearson]

🚀

[codecov]

Codecov Report

Merging #4181 (dcc273b) into master (1aa0e5a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4181      +/-   ##
==========================================
- Coverage   82.64%   82.63%   -0.02%     
==========================================
  Files         256      256              
  Lines       32569    32574       +5     
==========================================
  Hits        26918    26918              
- Misses       5651     5656       +5     

Flag	Coverage Δ
functest	55.95% <88.88%> (+0.01%)	⬆️
unittest	73.34% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
wandb/errors/__init__.py	92.85% <100.00%> (+0.35%)	⬆️
wandb/sdk/wandb_artifacts.py	81.79% <100.00%> (ø)
wandb/sdk/wandb_run.py	90.88% <100.00%> (+0.01%)	⬆️
wandb/agents/pyagent.py	70.80% <0.00%> (-1.61%)	⬇️
wandb/sdk/lib/sock_client.py	93.12% <0.00%> (-1.06%)	⬇️
wandb/sdk/internal/internal_api.py	86.46% <0.00%> (-0.52%)	⬇️
wandb/sdk/wandb_setup.py	88.44% <0.00%> (-0.51%)	⬇️
wandb/sdk/interface/interface_shared.py	85.88% <0.00%> (-0.31%)	⬇️
wandb/sdk/lib/git.py	79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py	90.12% <0.00%> (ø)
... and 3 more