New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sweeps): Move run configs from entrypoint into params #4164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4164 +/- ##
==========================================
+ Coverage 82.68% 82.72% +0.04%
==========================================
Files 256 256
Lines 32541 32533 -8
==========================================
+ Hits 26906 26914 +8
+ Misses 5635 5619 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have some time could you elaborate on what couldn't be done by making this change? Im concerned baout loss of functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 For future readers: we talked about the implications of moving this out of the args and into run config. Users constant args will be supported by jobs which gets rid of the loss of any functionality.
Fixes WB-10661
Description
Moves run configs from going through entrypoint in
launch_add
to going through theparams
kwarg.Testing
How was this PR tested?
Checklist