Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sweeps): Move run configs from entrypoint into params #4164

Merged
merged 5 commits into from Aug 23, 2022

Conversation

hu-po
Copy link
Contributor

@hu-po hu-po commented Aug 23, 2022

Fixes WB-10661

Description

Moves run configs from going through entrypoint in launch_add to going through the params kwarg.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #4164 (3704207) into master (4427067) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 3704207 differs from pull request most recent head 9bcc788. Consider uploading reports for the commit 9bcc788 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4164      +/-   ##
==========================================
+ Coverage   82.68%   82.72%   +0.04%     
==========================================
  Files         256      256              
  Lines       32541    32533       -8     
==========================================
+ Hits        26906    26914       +8     
+ Misses       5635     5619      -16     
Flag Coverage Δ
functest 55.02% <ø> (+0.04%) ⬆️
unittest 73.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/sweeps/scheduler.py 100.00% <ø> (ø)
wandb/sdk/launch/sweeps/scheduler_sweep.py 98.61% <ø> (-0.14%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 91.16% <0.00%> (+0.24%) ⬆️
wandb/sdk/internal/file_stream.py 89.86% <0.00%> (+1.01%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+4.93%) ⬆️

@hu-po hu-po marked this pull request as ready for review August 23, 2022 15:44
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have some time could you elaborate on what couldn't be done by making this change? Im concerned baout loss of functionality

wandb/sdk/launch/sweeps/scheduler_sweep.py Outdated Show resolved Hide resolved
@hu-po hu-po requested a review from KyleGoyette August 23, 2022 23:04
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 For future readers: we talked about the implications of moving this out of the args and into run config. Users constant args will be supported by jobs which gets rid of the loss of any functionality.

@hu-po hu-po enabled auto-merge (squash) August 23, 2022 23:06
@hu-po hu-po merged commit 4c87b36 into master Aug 23, 2022
@hu-po hu-po deleted the feature/sweeps-launch-run-configs branch August 23, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants