New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add better error handling when tearing down service #4161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
=======================================
Coverage 82.65% 82.66%
=======================================
Files 256 256
Lines 32541 32546 +5
=======================================
+ Hits 26896 26903 +7
+ Misses 5645 5643 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
changed the title
check this
add better error handling when tearing down service
Aug 24, 2022
raubitsj
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-10725
Description
What does the PR do?
When using
wandb.teardown
the system could be in a bad state. For example in a notebook setup where the service was closed, due to some kill signal, but token env variable is still present and the setup singleton was not removed. This PR adds better error handling for cases when some of the teardown operations could cause an exception and guarantee that the env variable is cleared to force reconnect on a new call toinit
.Testing
How was this PR tested?
Add a unit tests that tries to create a bad state and see that the error was handled.
Checklist