Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds debug mode for pytest unit tests #4145

Merged
merged 4 commits into from Aug 25, 2022
Merged

Adds debug mode for pytest unit tests #4145

merged 4 commits into from Aug 25, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Aug 19, 2022

Description

In this PR:

  • Provision an admin user to use with the app when running pytest tests. Users generated per requesting test are not removed at the end of the test so that developers can inspect the app with the admin account at the end of the test session.

image

- Unset global wandb objects at the end of each test to improve isolation.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@dmitryduev dmitryduev requested a review from a team August 19, 2022 22:33
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #4145 (5a036c7) into master (743a0a6) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4145      +/-   ##
==========================================
- Coverage   82.69%   82.61%   -0.08%     
==========================================
  Files         256      256              
  Lines       32534    32534              
==========================================
- Hits        26905    26879      -26     
- Misses       5629     5655      +26     
Flag Coverage Δ
functest 55.01% <ø> (+0.03%) ⬆️
unittest 73.33% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/lib/timed_input.py 44.04% <0.00%> (-14.29%) ⬇️
wandb/docker/auth.py 49.55% <0.00%> (-1.77%) ⬇️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/service/service.py 89.15% <0.00%> (-1.21%) ⬇️
wandb/sdk/data_types/base_types/media.py 92.08% <0.00%> (-0.72%) ⬇️
wandb/sdk/internal/internal_api.py 86.46% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.44% <0.00%> (-0.51%) ⬇️
wandb/sdk/wandb_settings.py 94.56% <0.00%> (-0.28%) ⬇️
wandb/sdk/wandb_run.py 90.92% <0.00%> (-0.25%) ⬇️
wandb/apis/public.py 82.25% <0.00%> (-0.20%) ⬇️
... and 5 more

@dmitryduev dmitryduev marked this pull request as ready for review August 23, 2022 01:23
@dmitryduev dmitryduev merged commit 35b16e3 into master Aug 25, 2022
@dmitryduev dmitryduev deleted the debug-admin branch August 25, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants