Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): add support for arguments in Jobs #4129

Merged
merged 21 commits into from Aug 25, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Aug 17, 2022

Fixes WB-10574
Fixes #NNNN

Description

Adds support for args in jobs. When a job is saved saves the args into the source and will automatically use these args again when the job is called.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #4129 (1ac03b7) into master (a298f69) will increase coverage by 0.07%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4129      +/-   ##
==========================================
+ Coverage   82.59%   82.66%   +0.07%     
==========================================
  Files         256      256              
  Lines       32534    32541       +7     
==========================================
+ Hits        26872    26901      +29     
+ Misses       5662     5640      -22     
Flag Coverage Δ
functest 55.95% <42.85%> (+0.98%) ⬆️
unittest 73.39% <57.14%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 91.16% <ø> (ø)
wandb/apis/public.py 82.64% <71.42%> (+0.39%) ⬆️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/data_types/_dtypes.py 94.62% <0.00%> (+0.21%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 86.98% <0.00%> (+0.51%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+4.93%) ⬆️

@KyleGoyette KyleGoyette changed the title support args in jobs feat(launch): add support for arguments in Jobs Aug 19, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review August 19, 2022 03:03
Copy link
Contributor

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the functional test, going to have to start using those...

@KyleGoyette KyleGoyette merged commit 43e8ead into master Aug 25, 2022
@KyleGoyette KyleGoyette deleted the launch/job-support-entrypoint-args branch August 25, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants