New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch): add support for arguments in Jobs #4129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/client into launch/job-support-entrypoint-args
Codecov Report
@@ Coverage Diff @@
## master #4129 +/- ##
==========================================
+ Coverage 82.59% 82.66% +0.07%
==========================================
Files 256 256
Lines 32534 32541 +7
==========================================
+ Hits 26872 26901 +29
+ Misses 5662 5640 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…/client into launch/job-support-entrypoint-args
KyleGoyette
changed the title
support args in jobs
feat(launch): add support for arguments in Jobs
Aug 19, 2022
gtarpenning
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the functional test, going to have to start using those...
hu-po
reviewed
Aug 24, 2022
hu-po
reviewed
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-10574
Fixes #NNNN
Description
Adds support for args in jobs. When a job is saved saves the args into the source and will automatically use these args again when the job is called.
Testing
How was this PR tested?
Checklist