New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance by increase recv size on service socket #4122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what the rational for the change is. Is the only downside for larger buffer sizes more memory consumption or am I missing something?
I did some micro benchmarks and i saw no improvement so i was going to go a bit more conservative. I think larger should be better, but marginally now that the underlying buffer management was fixed in the sender and receiver. |
Codecov Report
@@ Coverage Diff @@
## master #4122 +/- ##
==========================================
+ Coverage 82.72% 82.76% +0.04%
==========================================
Files 256 256
Lines 32568 32576 +8
==========================================
+ Hits 26941 26961 +20
+ Misses 5627 5615 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
We were reading in very small chunks... This change prefers reading in 128kB size chunks.
Testing
See #4119 for testing notes