Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sweeps): Look for launch job in sweep config #4120

Merged
merged 3 commits into from Aug 18, 2022

Conversation

hu-po
Copy link
Contributor

@hu-po hu-po commented Aug 17, 2022

Fixes WB-10606

Description

When running a sweep via the CLI, the job field can now be specified both in the sweep config and the launch config (with the sweep config taking precedence).

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #4120 (ab709f4) into master (cce611e) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head ab709f4 differs from pull request most recent head ead2cdb. Consider uploading reports for the commit ead2cdb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4120      +/-   ##
==========================================
- Coverage   82.74%   82.70%   -0.04%     
==========================================
  Files         256      256              
  Lines       32561    32515      -46     
==========================================
- Hits        26941    26892      -49     
- Misses       5620     5623       +3     
Flag Coverage Δ
functest 54.99% <0.00%> (+0.13%) ⬆️
unittest 73.44% <71.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/cli/cli.py 69.01% <71.42%> (+0.01%) ⬆️
wandb/sdk/wandb_watch.py 74.54% <0.00%> (-6.94%) ⬇️
wandb/sdk/lib/sock_client.py 89.92% <0.00%> (-2.34%) ⬇️
wandb/wandb_torch.py 59.93% <0.00%> (-1.36%) ⬇️
wandb/sdk/internal/internal_api.py 86.50% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.50% <0.00%> (-0.50%) ⬇️
wandb/sdk/service/service.py 89.87% <0.00%> (-0.49%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/apis/public.py 82.63% <0.00%> (+0.19%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@hu-po hu-po marked this pull request as ready for review August 17, 2022 21:21
@hu-po hu-po requested a review from KyleGoyette August 17, 2022 21:21
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hu-po hu-po merged commit 4e81f2d into master Aug 18, 2022
@hu-po hu-po deleted the feat/launch-job-in-sweeps-config branch August 18, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants