New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FetchRunQueueItemById query -- clientside #4106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new query looks correct, as does the handling for it. But we'll need to support both the new and old query. Since we have users on older versions of the server. Try the new query, and if it fails (I think with a 500 server error) fallback to the other method.
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.01%
==========================================
Files 256 256
Lines 32555 32519 -36
==========================================
- Hits 26913 26887 -26
+ Misses 5642 5632 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2069fbc
to
3326440
Compare
9b07326
to
b6bf0a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits but looks good I think
2a398ac
to
f1a2d19
Compare
Fixes WB-10133
Description
This is the client side of a new query that grabs run queue items by id rather than grabbing all of them and looping through to find the one we want.
Testing
test_launch_add_base_queued_run
has good coverage on this as the function just replaces the older method.