Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FetchRunQueueItemById query -- clientside #4106

Merged
merged 11 commits into from Aug 26, 2022

Conversation

gtarpenning
Copy link
Contributor

@gtarpenning gtarpenning commented Aug 15, 2022

Fixes WB-10133

Description

This is the client side of a new query that grabs run queue items by id rather than grabbing all of them and looping through to find the one we want.

Testing

test_launch_add_base_queued_run has good coverage on this as the function just replaces the older method.

@gtarpenning gtarpenning marked this pull request as draft August 15, 2022 23:22
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new query looks correct, as does the handling for it. But we'll need to support both the new and old query. Since we have users on older versions of the server. Try the new query, and if it fails (I think with a 500 server error) fallback to the other method.

wandb/apis/public.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #4106 (2a398ac) into master (f838ebe) will increase coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head 2a398ac differs from pull request most recent head f1a2d19. Consider uploading reports for the commit f1a2d19 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4106      +/-   ##
==========================================
+ Coverage   82.66%   82.68%   +0.01%     
==========================================
  Files         256      256              
  Lines       32555    32519      -36     
==========================================
- Hits        26913    26887      -26     
+ Misses       5642     5632      -10     
Flag Coverage Δ
functest 54.98% <3.84%> (-0.75%) ⬇️
unittest 73.40% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 82.34% <66.66%> (-0.31%) ⬇️
wandb/sdk/wandb_watch.py 74.54% <0.00%> (-6.94%) ⬇️
wandb/sdk/lib/sock_client.py 89.92% <0.00%> (-3.20%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (-2.47%) ⬇️
wandb/errors/term.py 93.47% <0.00%> (-2.18%) ⬇️
wandb/wandb_torch.py 59.93% <0.00%> (-1.36%) ⬇️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/internal/file_stream.py 88.85% <0.00%> (-1.02%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (-0.62%) ⬇️
wandb/sdk/internal/internal_api.py 86.50% <0.00%> (-0.49%) ⬇️
... and 122 more

@gtarpenning gtarpenning force-pushed the launch-fetch-run-queue-item-query branch from 2069fbc to 3326440 Compare August 16, 2022 02:20
@gtarpenning gtarpenning marked this pull request as ready for review August 16, 2022 23:21
@gtarpenning gtarpenning force-pushed the launch-fetch-run-queue-item-query branch from 9b07326 to b6bf0a1 Compare August 16, 2022 23:54
wandb/apis/public.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but looks good I think

wandb/apis/public.py Outdated Show resolved Hide resolved
wandb/apis/public.py Show resolved Hide resolved
@gtarpenning gtarpenning force-pushed the launch-fetch-run-queue-item-query branch from 2a398ac to f1a2d19 Compare August 26, 2022 19:44
@gtarpenning gtarpenning enabled auto-merge (squash) August 26, 2022 19:45
@gtarpenning gtarpenning merged commit 939c8c7 into master Aug 26, 2022
@gtarpenning gtarpenning deleted the launch-fetch-run-queue-item-query branch August 26, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants