Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sweeps): Sweep scheduler cleanup and better tests #4100

Merged
merged 19 commits into from Aug 16, 2022

Conversation

hu-po
Copy link
Contributor

@hu-po hu-po commented Aug 15, 2022

Fixes WB-10588

Description

Cleans up some of the threading logic in the sweep scheduler. Adds better unit tests for sweep scheduler.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@hu-po hu-po changed the title feat(sweeps): Sweep scheduler cleanup better tests feat(sweeps): Sweep scheduler cleanup and better tests Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #4100 (730c7b5) into master (9053171) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 730c7b5 differs from pull request most recent head cbfc4b1. Consider uploading reports for the commit cbfc4b1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4100      +/-   ##
==========================================
+ Coverage   82.61%   82.63%   +0.01%     
==========================================
  Files         255      255              
  Lines       32370    32349      -21     
==========================================
- Hits        26741    26730      -11     
+ Misses       5629     5619      -10     
Flag Coverage Δ
functest 54.81% <0.00%> (+0.07%) ⬆️
unittest 73.34% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/sweeps/scheduler.py 100.00% <100.00%> (+2.87%) ⬆️
wandb/sdk/launch/sweeps/scheduler_sweep.py 98.75% <100.00%> (-1.25%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (-2.47%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/internal/internal_api.py 86.50% <0.00%> (+0.12%) ⬆️
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
wandb/sdk/lib/sock_client.py 91.36% <0.00%> (+1.43%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@hu-po hu-po marked this pull request as ready for review August 16, 2022 15:30
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some questions that I think warrant discussion

tests/unit_tests/test_sweep_scheduler.py Show resolved Hide resolved
wandb/sdk/launch/sweeps/scheduler.py Outdated Show resolved Hide resolved
wandb/sdk/launch/sweeps/scheduler.py Show resolved Hide resolved
wandb/sdk/launch/sweeps/scheduler_sweep.py Outdated Show resolved Hide resolved
@hu-po hu-po merged commit ccd51c9 into master Aug 16, 2022
@hu-po hu-po deleted the feat/improved-sweep-scheduler-with-testing branch August 16, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants