New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sweeps): Sweep scheduler cleanup and better tests #4100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4100 +/- ##
==========================================
+ Coverage 82.61% 82.63% +0.01%
==========================================
Files 255 255
Lines 32370 32349 -21
==========================================
- Hits 26741 26730 -11
+ Misses 5629 5619 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are some questions that I think warrant discussion
Fixes WB-10588
Description
Cleans up some of the threading logic in the sweep scheduler. Adds better unit tests for sweep scheduler.
Testing
How was this PR tested?
Checklist