Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallelism to functional testing #4096

Merged
merged 6 commits into from Aug 13, 2022
Merged

Add parallelism to functional testing #4096

merged 6 commits into from Aug 13, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Aug 13, 2022

Description

Adds CI parallelism to functional tests
Screen Shot 2022-08-13 at 10 50 38 AM
parallelism for base (windows and linux).

Windows setup takes almost 5 minutes so this is a bit wasteful, will probably want to add caching back or move to docker cache.
Screen Shot 2022-08-13 at 11 00 22 AM

Depends on:

Testing

Manual testing

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #4096 (5c2138a) into master (5853e4e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4096   +/-   ##
=======================================
  Coverage   82.61%   82.62%           
=======================================
  Files         255      255           
  Lines       32359    32359           
=======================================
+ Hits        26734    26736    +2     
+ Misses       5625     5623    -2     
Flag Coverage Δ
functest 54.75% <ø> (+0.02%) ⬆️
unittest 73.36% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/internal_api.py 86.39% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.50% <0.00%> (-0.50%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@raubitsj raubitsj changed the title Add yea splits Add parallelism to functional testing Aug 13, 2022
@raubitsj raubitsj added this to the sdk-2022-09.1 milestone Aug 13, 2022
@raubitsj raubitsj marked this pull request as ready for review August 13, 2022 17:52
@raubitsj raubitsj requested a review from a team August 13, 2022 17:55
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@raubitsj raubitsj merged commit fc2f267 into master Aug 13, 2022
@raubitsj raubitsj deleted the yea-add-split branch August 13, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants