Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move _timestamp logic to the internal process #4087

Merged
merged 3 commits into from Aug 11, 2022
Merged

move _timestamp logic to the internal process #4087

merged 3 commits into from Aug 11, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 11, 2022

Fixes WB-10592

Description

What does the PR do?

This PR cleans up the partial_history_callback and moves the _timestamp logic to the internal process

Testing

How was this PR tested?

If this fix is correct, the test is that all the existing tests don't break

@kptkin kptkin changed the title move _timestamp to interface move _timestamp logic to the internal process Aug 11, 2022
@kptkin kptkin requested a review from a team August 11, 2022 21:20
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4087 (8fe532a) into master (917dd7e) will increase coverage by 7.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
+ Coverage   75.26%   82.74%   +7.48%     
==========================================
  Files         255      255              
  Lines       32267    32266       -1     
==========================================
+ Hits        24286    26699    +2413     
+ Misses       7981     5567    -2414     
Flag Coverage Δ
functest 54.91% <100.00%> (+0.03%) ⬆️
unittest 73.44% <100.00%> (+7.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_run.py 91.18% <ø> (+2.83%) ⬆️
wandb/sdk/interface/interface.py 96.69% <100.00%> (+0.01%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 87.65% <0.00%> (-4.94%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_settings.py 94.83% <0.00%> (+0.97%) ⬆️
wandb/sdk/service/server_sock.py 92.89% <0.00%> (+1.01%) ⬆️
wandb/sdk/lib/sock_client.py 91.36% <0.00%> (+1.43%) ⬆️
wandb/sdk/wandb_init.py 85.43% <0.00%> (+2.52%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️
... and 28 more

wandb/sdk/wandb_run.py Show resolved Hide resolved
@dmitryduev dmitryduev enabled auto-merge (squash) August 11, 2022 22:27
@dmitryduev dmitryduev merged commit 0691d09 into master Aug 11, 2022
@dmitryduev dmitryduev deleted the WB-10592 branch August 11, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants