Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-10593] Launch kubernetes support taints and tolerations #4086

Merged
merged 2 commits into from Aug 11, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Aug 11, 2022

Fixes WB-10593
Fixes #NNNN

Description

Adds handling for a tolerations key in the kubernetes runner which can be used for taints and tolerations

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@KyleGoyette KyleGoyette changed the title add tolerations [WB-10593] Launch kubernetes support taints and tolerations Aug 11, 2022
@KyleGoyette KyleGoyette marked this pull request as ready for review August 11, 2022 20:19
Copy link
Contributor

@hu-po hu-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4086 (673a745) into master (d77c529) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 673a745 differs from pull request most recent head 0fb112f. Consider uploading reports for the commit 0fb112f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
+ Coverage   82.71%   82.75%   +0.03%     
==========================================
  Files         255      255              
  Lines       32266    32268       +2     
==========================================
+ Hits        26690    26703      +13     
+ Misses       5576     5565      -11     
Flag Coverage Δ
functest 54.92% <0.00%> (+0.01%) ⬆️
unittest 73.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/runner/kubernetes.py 89.45% <100.00%> (+0.08%) ⬆️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/cli/cli.py 70.29% <0.00%> (+0.09%) ⬆️
wandb/sdk/wandb_run.py 91.26% <0.00%> (+0.24%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@KyleGoyette KyleGoyette enabled auto-merge (squash) August 11, 2022 20:40
@KyleGoyette KyleGoyette merged commit c9a6ac1 into master Aug 11, 2022
@KyleGoyette KyleGoyette deleted the launch/kubernetes-tolerations branch August 11, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants