Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that the wandb_init fixture args are in sync with wandb.init() #4079

Merged
merged 1 commit into from Aug 11, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Aug 11, 2022

Description

A follow-up PR on 4066.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@dmitryduev dmitryduev requested review from kptkin and a team August 11, 2022 01:09
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4079 (2767eb0) into master (6db0993) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4079   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         255      255           
  Lines       32266    32266           
=======================================
+ Hits        26701    26702    +1     
+ Misses       5565     5564    -1     
Flag Coverage Δ
functest 54.94% <ø> (+0.03%) ⬆️
unittest 73.46% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (-2.47%) ⬇️
wandb/sdk/wandb_login.py 94.54% <0.00%> (-0.61%) ⬇️
wandb/sdk/internal/internal_api.py 86.39% <0.00%> (-0.52%) ⬇️
wandb/sdk/wandb_setup.py 88.50% <0.00%> (-0.50%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/cli/cli.py 70.29% <0.00%> (+0.09%) ⬆️
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
wandb/sdk/lib/sock_client.py 91.36% <0.00%> (+1.43%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@dmitryduev dmitryduev merged commit 5d6a539 into master Aug 11, 2022
@dmitryduev dmitryduev deleted the check-wandb-init-fixture-args branch August 11, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants