Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit error message for double uri/docker-image [WB-10302] #4069

Merged
merged 2 commits into from Aug 9, 2022

Conversation

gtarpenning
Copy link
Contributor

Fixes WB-10302

Description

One-Liner improved error messaging for entering both a URI and docker image path

Testing

Sending both or one or none and getting my fancy new error message.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #4069 (e851f31) into master (e36228d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e851f31 differs from pull request most recent head 2015335. Consider uploading reports for the commit 2015335 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4069   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         255      255           
  Lines       32264    32266    +2     
=======================================
+ Hits        26694    26696    +2     
  Misses       5570     5570           
Flag Coverage Δ
functest 54.97% <0.00%> (+0.06%) ⬆️
unittest 73.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/utils.py 92.98% <100.00%> (+0.04%) ⬆️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/jupyter.py 56.64% <0.00%> (-0.40%) ⬇️
wandb/sdk/wandb_run.py 90.95% <0.00%> (-0.25%) ⬇️
wandb/sdk/lib/git.py 78.39% <0.00%> (ø)
wandb/sdk/wandb_setup.py 89.00% <0.00%> (+0.50%) ⬆️
wandb/sdk/lib/printer.py 90.84% <0.00%> (+0.65%) ⬆️
wandb/errors/term.py 95.65% <0.00%> (+2.17%) ⬆️
wandb/sdk/internal/meta.py 90.18% <0.00%> (+3.06%) ⬆️

Copy link
Contributor

@hu-po hu-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gtarpenning gtarpenning merged commit 2cb6495 into master Aug 9, 2022
@gtarpenning gtarpenning deleted the launch-double-uri-errmsg branch August 9, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants