New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch): add a new --build
flag for building and then pushing the image to a queue
#4061
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
==========================================
+ Coverage 83.01% 83.10% +0.08%
==========================================
Files 259 259
Lines 32925 32980 +55
==========================================
+ Hits 27334 27408 +74
+ Misses 5591 5572 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This comment was marked as outdated.
This comment was marked as outdated.
…unch-build-on-queue
cfe5b8e
to
ac43e36
Compare
@KyleGoyette holy **** we did the thing ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change, then I think it LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
--build
flag for building then pushing the image to a queue--build
flag for building and then pushing the image to a queue
Fixes WB-10393
Description
When passing in the new
--build
flag, launch uses a URI to build a docker image and create a “Job” artifact, then pushes a run queue item that uses this job artifact to run the associated job.Overwrites a given URI, requires the
--queue
flag to be set.Testing
New test using the relay server:
tests/unit_tests/test_launch_add.py