Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): add a new --build flag for building and then pushing the image to a queue #4061

Merged
merged 127 commits into from Nov 16, 2022

Conversation

gtarpenning
Copy link
Contributor

@gtarpenning gtarpenning commented Aug 5, 2022

Fixes WB-10393

Description

When passing in the new --build flag, launch uses a URI to build a docker image and create a “Job” artifact, then pushes a run queue item that uses this job artifact to run the associated job.

Overwrites a given URI, requires the --queue flag to be set.

Testing

New test using the relay server: tests/unit_tests/test_launch_add.py

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #4061 (bbcf958) into main (d0df1dd) will increase coverage by 0.08%.
The diff coverage is 94.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
+ Coverage   83.01%   83.10%   +0.08%     
==========================================
  Files         259      259              
  Lines       32925    32980      +55     
==========================================
+ Hits        27334    27408      +74     
+ Misses       5591     5572      -19     
Flag Coverage Δ
functest 56.94% <29.70%> (+0.15%) ⬆️
unittest 73.31% <94.05%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/runner/local_container.py 80.18% <ø> (ø)
wandb/sdk/launch/utils.py 92.97% <83.33%> (+0.38%) ⬆️
wandb/sdk/launch/builder/build.py 90.79% <88.88%> (-0.39%) ⬇️
wandb/sdk/wandb_run.py 90.60% <95.45%> (-0.02%) ⬇️
wandb/cli/cli.py 69.40% <100.00%> (+0.29%) ⬆️
wandb/sdk/launch/_project_spec.py 93.04% <100.00%> (+0.05%) ⬆️
wandb/sdk/launch/launch.py 83.72% <100.00%> (+0.20%) ⬆️
wandb/sdk/launch/launch_add.py 100.00% <100.00%> (+19.56%) ⬆️
wandb/sdk/lib/sock_client.py 93.12% <0.00%> (-1.06%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
... and 7 more

@gtarpenning

This comment was marked as outdated.

wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
@gtarpenning
Copy link
Contributor Author

gtarpenning commented Nov 14, 2022

@KyleGoyette holy **** we did the thing ✅

@gtarpenning gtarpenning requested review from KyleGoyette and removed request for hu-po November 14, 2022 21:35
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, then I think it LGTM

Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtarpenning gtarpenning merged commit b96107d into main Nov 16, 2022
@gtarpenning gtarpenning deleted the launch-build-on-queue branch November 16, 2022 00:22
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
@kptkin kptkin changed the title feat(launch): Creates a --build flag for building then pushing the image to a queue feat(launch): add a new --build flag for building and then pushing the image to a queue Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants