Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raytune examples / tests #4053

Merged
merged 20 commits into from Aug 9, 2022
Merged

Add raytune examples / tests #4053

merged 20 commits into from Aug 9, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Aug 4, 2022

Description

Add examples / tests for ray/tune

Also:

  • Updated coveragetool to detect .coveragerc issues (found one, imports was there and didnt need to be)
  • Updated .coveragerc to be sorted, because sorted is better

Requires:

Possible future work:

  • add more asserts to some of the tests, a little tedious, but should be done
  • debug or document that ray1.12 not supported with wandb 1.13.0+ or workaround is needed (disable service)? (see t5_ test in ray)

Testing

These are tests.

@raubitsj raubitsj changed the title Add raytune examples / tests [WIP] Add raytune examples / tests Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #4053 (fae2795) into master (e36228d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head fae2795 differs from pull request most recent head 162a528. Consider uploading reports for the commit 162a528 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4053      +/-   ##
==========================================
+ Coverage   82.73%   82.75%   +0.01%     
==========================================
  Files         255      255              
  Lines       32264    32263       -1     
==========================================
+ Hits        26694    26699       +5     
+ Misses       5570     5564       -6     
Flag Coverage Δ
functest 55.20% <ø> (+0.29%) ⬆️
unittest 73.45% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/sdk/wandb_run.py 90.95% <0.00%> (-0.25%) ⬇️
wandb/sdk/wandb_settings.py 94.83% <0.00%> (+0.13%) ⬆️
wandb/sdk/service/streams.py 93.85% <0.00%> (+0.43%) ⬆️
wandb/sdk/internal/stats.py 66.83% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/git.py 79.01% <0.00%> (+0.61%) ⬆️
wandb/sdk/lib/sock_client.py 91.36% <0.00%> (+1.43%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.68%) ⬆️

@raubitsj raubitsj marked this pull request as ready for review August 4, 2022 22:00
@raubitsj raubitsj requested a review from a team August 4, 2022 22:00
@raubitsj raubitsj changed the title [WIP] Add raytune examples / tests Add raytune examples / tests Aug 4, 2022
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tox.ini Outdated Show resolved Hide resolved
@raubitsj raubitsj enabled auto-merge (squash) August 9, 2022 20:37
@raubitsj raubitsj disabled auto-merge August 9, 2022 20:38
@raubitsj raubitsj merged commit 8033b7d into master Aug 9, 2022
@raubitsj raubitsj deleted the add-raytune-examples branch August 9, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants