Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sweeps): Sweeps on Launch on Kubernetes #4035

Merged
merged 104 commits into from Aug 12, 2022
Merged

feat(sweeps): Sweeps on Launch on Kubernetes #4035

merged 104 commits into from Aug 12, 2022

Conversation

hu-po
Copy link
Contributor

@hu-po hu-po commented Aug 2, 2022 •
edited

WB-10468

Description

  • Fixes to URI and Job parsing in Launch utilities
  • Fixes to Kaniko builder to prevent repeated building (checking on ECR)
  • Multiple worker threads in Scheduler
  • Added pretty log prefixes to launch and scheduler modules

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

hu-po and others added 30 commits July 12, 2022 15:27
@hu-po
possible job type
20cd33d
@hu-po
artifact
81021a6
@hu-po
format
c2d3725
@hu-po
rename to queued_run
64bffb5
@hu-po
todos
aadf4dd
@hu-po
configurable number of agents in sweep scheduler
1e5616b
@hu-po
remove sweep source, create artifact in cli
d0bcd9a
@hu-po
Use put function to upload artifact
4459505
@hu-po
move multi worker to seperate branch
7f433ef
@hu-po
job name to construct artifact
90fc383
@hu-po
Add job to scheduler
ce1c7b0
@hu-po
remove uri
257e36d
@hu-po
sweep cli takes job
81a3912
@hu-po
Merge branch 'master' into feature/sweep-launch-jobs
be27077
@hu-po
format
c8d7eaa
@hu-po
Merge branch 'feature/sweep-launch-jobs' of github.com:wandb/client i…
5c01ea7 
…nto feature/sweep-launch-jobs
@hu-po
uri as default
86132e0
@hu-po
default to local directoy for uri
24f97b1
@hu-po
back to None
88ed36a
@hu-po
Merge branch 'master' into feature/sweep-launch-jobs
6403f5b
@hu-po
remove public api
eb02b26
@hu-po
Merge branch 'master' into feature/sweep-launch-jobs
65340b8
@hu-po
scheduler does not have job
b66c721
@hu-po
more robust uri
54c1e50
@hu-po
upsert sweep issue
89e8732
@hu-po
add job kwarg to cli tests
e0d031a
@hu-po
formatting
a470685
@hu-po
artifact over repo
504ba8b
@hu-po
Merge branch 'master' into feature/sweep-launch-jobs
aca393a
@hu-po
format
73cb083
@hu-po hu-po requested a review from KyleGoyette August 10, 2022 15:32
KyleGoyette
KyleGoyette approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

@hu-po hu-po enabled auto-merge (squash) August 11, 2022 21:00
@hu-po hu-po disabled auto-merge August 11, 2022 21:25
@hu-po hu-po enabled auto-merge (squash) August 11, 2022 21:33
@hu-po hu-po merged commit b1270e0 into master Aug 12, 2022
@hu-po hu-po deleted the feature/sweep-launch-resource-args branch August 12, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleGoyette KyleGoyette KyleGoyette approved these changes

@gtarpenning gtarpenning Awaiting requested review from gtarpenning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hu-po @KyleGoyette