New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch gitversion error message #4028
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4028 +/- ##
==========================================
+ Coverage 80.07% 82.69% +2.61%
==========================================
Files 255 255
Lines 32266 32273 +7
==========================================
+ Hits 25837 26688 +851
+ Misses 6429 5585 -844
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but lets write a test using both master and main so we'll know if this code path breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
3ae0c9d
to
d745237
Compare
Partially Addresses WB-9990
Description
Updates error messages to provide more explicit handling when cloning from a git repo fails. This is usually due to an incorrect branch, either through a typo in the
git-version
parameter or because the there is nomaster
branch.As GitHub has changed their default branch to
main
, this error will likely increasingly occur, thus better handling and error messages seem appropriate. Eventually we might want to change the default branch frommaster
->main
.Testing
Multiple variations of branch configs on a remote git repo.