Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch gitversion error message #4028

Merged
merged 12 commits into from Aug 12, 2022
Merged

Conversation

gtarpenning
Copy link
Contributor

Partially Addresses WB-9990

Description

Updates error messages to provide more explicit handling when cloning from a git repo fails. This is usually due to an incorrect branch, either through a typo in the git-version parameter or because the there is no master branch.

As GitHub has changed their default branch to main, this error will likely increasingly occur, thus better handling and error messages seem appropriate. Eventually we might want to change the default branch from master -> main.

Testing

Multiple variations of branch configs on a remote git repo.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4028 (350851e) into master (2cb6495) will increase coverage by 2.61%.
The diff coverage is 15.38%.

❗ Current head 350851e differs from pull request most recent head 484365c. Consider uploading reports for the commit 484365c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4028      +/-   ##
==========================================
+ Coverage   80.07%   82.69%   +2.61%     
==========================================
  Files         255      255              
  Lines       32266    32273       +7     
==========================================
+ Hits        25837    26688     +851     
+ Misses       6429     5585     -844     
Flag Coverage Δ
functest 54.92% <0.00%> (+5.01%) ⬆️
unittest 73.42% <15.38%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/utils.py 89.88% <15.38%> (-3.11%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 87.65% <0.00%> (-4.94%) ⬇️
wandb/sdk/lib/git.py 78.39% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.95% <0.00%> (+0.29%) ⬆️
wandb/sdk/internal/tb_watcher.py 88.03% <0.00%> (+0.33%) ⬆️
wandb/integration/keras/keras.py 74.03% <0.00%> (+0.38%) ⬆️
wandb/util.py 86.33% <0.00%> (+0.43%) ⬆️
wandb/apis/public.py 82.19% <0.00%> (+0.43%) ⬆️
wandb/sdk/wandb_setup.py 88.50% <0.00%> (+0.50%) ⬆️
... and 44 more

wandb/sdk/launch/utils.py Outdated Show resolved Hide resolved
wandb/sdk/launch/utils.py Outdated Show resolved Hide resolved
wandb/sdk/launch/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets write a test using both master and main so we'll know if this code path breaks.

Copy link
Contributor

@KyleGoyette KyleGoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gtarpenning gtarpenning enabled auto-merge (squash) August 12, 2022 16:21
@gtarpenning gtarpenning force-pushed the launch-gitversion-error-message branch from 3ae0c9d to d745237 Compare August 12, 2022 16:29
@gtarpenning gtarpenning merged commit 283fd8d into master Aug 12, 2022
@gtarpenning gtarpenning deleted the launch-gitversion-error-message branch August 12, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants